Codecov Report

Merging #370 (4e15834) into master (b8bc952) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #370   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files          39       39           
  Lines        1373     1373           
=======================================
  Hits         1340     1340           
  Misses         33       33           

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b541add...4e15834. Read the comment docs.

Because we are using ci it won't trigger a new pypi deployment. Should we deploy manually or use fix instead?

We should probably update the https://github.com/commitizen-tools/commitizen/blob/master/docs/config.md
Unfortunately I think this is a breaking change, we could fix it if we update the config before updating the version numbers I think.

https://github.com/commitizen-tools/commitizen/blob/master/commitizen/commands/bump.py#L179
https://github.com/commitizen-tools/commitizen/blob/master/commitizen/commands/bump.py#L211

What do you think?

Because we are using ci it won't trigger a new pypi deployment. Should we deploy manually or use fix instead?

Yes, I think it would be better that we manually push this one. Forget to mention it 🤦🏻

We should probably update the https://github.com/commitizen-tools/commitizen/blob/master/docs/config.md

I agree we should update the documentation as well.

Unfortunately I think this is a breaking change, we could fix it if we update the config before updating the version numbers I think.

https://github.com/commitizen-tools/commitizen/blob/master/commitizen/commands/bump.py#L179
https://github.com/commitizen-tools/commitizen/blob/master/commitizen/commands/bump.py#L211

I'm afraid I did not understand what you mean. Could you describe it a bit more? 🙂

I think a solution would be to check for all occurrences when running the regex, that would solve the reported issue and the issue with not modifying the poetry version.

Before we were updating all changes in a file, right? now it seems like we update only one

Edit: Sorry, I didn't mean this PR, I mean the change that forces us to have 2 items in the version_files

I think what you propose makes sense 👍 I'm thinking of first manually push 2.7.1, then merge this one. After all these step, we could create an issue to fix it. What do you think of the steps?

I would only update the version in the tool.poetry. If we fix the version_files, the one we currently have configured should work, right?
I will publish manually to pypi

Sounds good 👍 Then, I'll close this PR